[core][flink][lumina] Allow building Lumina global index on DV-enabled tables - #8930
Draft
XiaoHongbo-Hope wants to merge 1 commit into
Draft
Conversation
XiaoHongbo-Hope
force-pushed
the
feature/lumina-index-support-dv-tables
branch
3 times, most recently
from
July 30, 2026 13:59
ef31d32 to
5b03c02
Compare
XiaoHongbo-Hope
marked this pull request as draft
July 30, 2026 14:08
…d tables GenericGlobalIndexBuilder rejected every generic (non-btree/bitmap) global index on deletion-vector tables. Lumina vector search already filters DV-deleted rows at read time via the live-row pre-filter, so building the index over all physical rows (a superset) is safe. Add an opt-in GlobalIndexerFactory.supportsDeletionVectors() capability (default false), override it to true in Lumina, and relax the guard to allow only opt-in index types on DV tables while still rejecting the rest. Wires the resolved index type through the builder.
XiaoHongbo-Hope
force-pushed
the
feature/lumina-index-support-dv-tables
branch
from
July 30, 2026 14:13
5b03c02 to
5cb2e47
Compare
XiaoHongbo-Hope
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow building the Lumina vector global index on deletion-vector (DV) enabled
tables.
GenericGlobalIndexBuilderrejected every generic (non-btree/bitmap)global index on DV tables. Lumina vector search already filters DV-deleted rows at
read time via the live-row pre-filter, so building the index over all physical rows
(a superset) is safe.
Change
GlobalIndexerFactory.supportsDeletionVectors()capability(default
false), mirroring the existingsupportsFullTextSearch().truein Lumina.the rest; wire the resolved index type through the builder.
Dependencies / merge order
This PR only relaxes the build-side guard. Correctness of reads on DV tables relies
on two independent read-path fixes, which were split out and should merge before
this one:
(The union / two-phase live-row fix landed earlier in #8939.)